Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic SVGOverlay to expose SVG DOM element #6517

Merged
merged 3 commits into from Apr 30, 2019
Merged

Added basic SVGOverlay to expose SVG DOM element #6517

merged 3 commits into from Apr 30, 2019

Conversation

zsavajji
Copy link
Contributor

Adds a new Overlay class to display SVG elements and possibly retrieve the DOM element reference, to enable interactive SVGs into Leaflet maps.
Based onto the advice given into #5757.

src/layer/SVGOverlay.js Outdated Show resolved Hide resolved
@zsavajji
Copy link
Contributor Author

Tried to improve it by loading an element with XHR, but i don't have much time now to wrap it all around.
I think it's better to keep it simple by now.

@zsavajji
Copy link
Contributor Author

Any updates on this @IvanSanchez ?

@espensgr
Copy link

espensgr commented Mar 8, 2019

Any progress on this? would love to get this feature for a project i'm working on

Copy link
Member

@IvanSanchez IvanSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might need to be tweaked afterwards.

Copy link
Sponsor Collaborator

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out locally - looks good 👍

@IvanSanchez
Copy link
Member

Checked it out locally - looks good +1

In it goes, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants