Added LeafDoc for toGeoJSON's precision - Issue #6344 #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perliedman
requested changes
Oct 25, 2018
There was a problem hiding this comment.
Hi and thanks for taking the time to look into this!
I think this needs some work, though. First, the precision parameter is optional, and should be marked as such: precision?: Number. I also think it should be made clear that precision in this contexts means the number of decimals places for coordinates, and that the default precision is 6.
|
Hi @perliedman, I updated the PR with your recommended changes. Please review and let me know if you have questions. |
perliedman
approved these changes
Jan 17, 2019
|
Nice! Thanks! |
Schleuse
pushed a commit
to Schleuse/Leaflet
that referenced
this pull request
Dec 3, 2019
…#6375) * Added LeafDoc for toGeoJSON's precision * Added LeafDoc for toGeoJSON's precision argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LeafDoc for toGeoJSON's precision argument - Issue #6344