Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests on Chrome/macOS CI job #9155

Open
mourner opened this issue Nov 2, 2023 · 3 comments
Open

Flaky tests on Chrome/macOS CI job #9155

mourner opened this issue Nov 2, 2023 · 3 comments

Comments

@mourner
Copy link
Member

mourner commented Nov 2, 2023

Looking through CI failures on main commits, it looks like it boils down to two flaky tests on the Chrome/macOS job:

  • Map.TouchZoom Layer is rendered correctly while pinch zoom when zoomAnim is false
  • GridLayer number of 256px tiles loaded in synchronous animated grid @800x600px Loads 290, unloads 275 tiles on MAD-TRD timeout (>10s)

Would be nice to fix this — flakiness is very detrimental to development process. Aditionally, the second issue is the longest test we have (9–10s) — fixing it will probably involve making it shorter in duration.

@mourner mourner added the tests label Nov 2, 2023
@mourner
Copy link
Member Author

mourner commented Nov 2, 2023

cc @plainheart — you added the first test, any ideas on making it more reliable in this environment?

@plainheart
Copy link
Contributor

Hello @mourner, the first test case was done with @Falke-Design's help in #8794. I'm unfamiliar with the test tool, so I'm sorry I can't give some useful ideas on improving the reliability.

@jonkoops jonkoops added this to the 2.0 milestone Nov 12, 2023
@jonkoops
Copy link
Collaborator

I am adding this to the 2.0 milestone, as I'd really like to get this sorted before release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants