Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help for map container keyboard shortcuts #9142

Closed
wants to merge 3 commits into from
Closed

Add help for map container keyboard shortcuts #9142

wants to merge 3 commits into from

Conversation

TaduJR
Copy link

@TaduJR TaduJR commented Oct 22, 2023

This change resolves #9131 by adding keyboard shortcuts modal for accessibility.

Falke-Design
Falke-Design requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@Falke-Design Falke-Design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we will add a modal like this, then it should be using the nativ methods. Additionally it should be possible to add and remove custom shortcuts.

@jonkoops
Copy link
Collaborator

Appreciate the effort of creating a PR, but it is very unlikely to get merged until pending discussion under #9131 is resolved. I would instead recommend putting this into a dedicated plugin, which we will more than gladly list on our plugins page if you like.

Closing this for now.

@jonkoops jonkoops closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Falke-Design Falke-Design Falke-Design requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help should be provided for the map container keyboard shortcuts [accessibility]
3 participants
@TaduJR @jonkoops @Falke-Design