Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirefoxNoTouch & `FirefoxTouch jobs are flaky #8454

Closed
mourner opened this issue Sep 22, 2022 · 9 comments
Closed

FirefoxNoTouch & `FirefoxTouch jobs are flaky #8454

mourner opened this issue Sep 22, 2022 · 9 comments
Labels
tests workflow Anything related to Leaflet development process and tools

Comments

@mourner
Copy link
Member

mourner commented Sep 22, 2022

I had to rerun these jobs a bunch of times today — they seem to be extra flaky lately. Worth investigating.

@mourner mourner added tests workflow Anything related to Leaflet development process and tools labels Sep 22, 2022
@mourner
Copy link
Member Author

mourner commented Sep 22, 2022

@Falke-Design
Copy link
Member

Or https://github.com/Falke-Design/Leaflet/actions/runs/3107093741/jobs/5034793690

Firefox 104.0 (Ubuntu 0.0.0) Popup "before each" hook in "Popup" FAILED
	done() called multiple times in hook <Popup "before each" hook in "Popup">; in addition, done() received error: Error: TypeError: el is undefined (src/LeafletWithGlobals.js:2538)

@mourner
Copy link
Member Author

mourner commented Sep 23, 2022

Most of the failures seem to be related to popup code for some reason. Here's another:

Chrome Headless 105.0.5195.102 (Linux x86_64) Popup L.Map#openPopup should not be closen when dragging map FAILED
	Error: Uncaught TypeError: Cannot read properties of undefined (reading '_leaflet_pos') (src/LeafletWithGlobals.js:2538)

@mourner
Copy link
Member Author

mourner commented Sep 26, 2022

Another common error looks like this:

Firefox 104.0 (Ubuntu 0.0.0) Popup L.Map#openPopup should not be closen when dragging map FAILED
	TypeError: el is undefined (src/LeafletWithGlobals.js:2538)

The intermittent failures are getting really bad, to the point that nearly any PR or commit will likely fail, so we have to do something about it. @Falke-Design @jonkoops any idea when it started doing this and how we can go about tracking this down?

@Falke-Design
Copy link
Member

The problem is that it is not happening on my local machine (Windows).

Maybe @IvanSanchez can reproduce the failed test on his linux and findout which commit is the problem.

@jonkoops
Copy link
Collaborator

Yeah, this is getting quite excessive. We'll have to get this stabilized ASAP.

@mourner
Copy link
Member Author

mourner commented Sep 26, 2022

It's possible that this is related to #8464 and could be fixed by #8478 🤞 At least all the tests surprisingly pass in that PR and the merged commit.

@mourner
Copy link
Member Author

mourner commented Sep 26, 2022

Looks like it's stable again now after #8478. Will reopen if it still happens

@mourner mourner closed this as completed Sep 26, 2022
@jonkoops
Copy link
Collaborator

What a strange bug, I wonder why these animations impact the tests so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests workflow Anything related to Leaflet development process and tools
Projects
None yet
Development

No branches or pull requests

3 participants