Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Leafdoc #7134

Closed
johnd0e opened this issue May 8, 2020 · 3 comments
Closed

Update Leafdoc #7134

johnd0e opened this issue May 8, 2020 · 3 comments
Labels
docs Improvements or additions to documentation

Comments

@johnd0e
Copy link
Collaborator

johnd0e commented May 8, 2020

Latest Leafdoc is still unpublished on npm, so Leaflet documentation is building with outdated Leafdoc.

The issue is already reported a year ago.

Besides of functionality, outdated Leafdoc currently is the source of critical vulnerabilities reported by npm during install (see #7133 (comment)).

@mondeja
Copy link
Contributor

mondeja commented May 8, 2020

I think that this pull can be merged to remove a security vulnerability during install.

Related to, this Leaflet issue has been closed but the error persists with current Leaflet master because Leafdoc has not been released after removing sander dependency, that was the source of the error.

So yes, we need a new Leafdoc version published in NPM:

  • Bump Leafdoc version to 1.6.0.
  • Publish it on NPM.
  • Bump Leafdoc version dependency in Leaflet package.json.

@IvanSanchez
Copy link
Member

I've been working on some (IMO much-needed) cleanup of the leafdoc regexes. Before publishing a new Leafdoc version, I'd appreciate any review of Leaflet/Leafdoc#52

@Falke-Design Falke-Design added the docs Improvements or additions to documentation label Oct 28, 2021
@Falke-Design
Copy link
Member

Version 2.3.0 of Leafdoc released on npm: https://www.npmjs.com/package/leafdoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants