lock rollup version #6647
Merged
lock rollup version #6647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
May 8, 2019
|
Good to lock the version for now, but I think we may be ready to ditch IE8 for good in the next release. Not sure if it should be called v1.6.0 or v2.0.0. |
|
@mourner That would be a breaking change, so I'd call it 2.0 |
Schleuse
pushed a commit
to Schleuse/Leaflet
that referenced
this pull request
Dec 3, 2019
* lock rollup version * revert karma-rollup-preprocessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6645
Closes #6646
legacyoption was removed in rollup@0.60.0 - see https://github.com/rollup/rollup/blob/master/CHANGELOG.md#0600This is breaking change for leaflet.
In order to support IE8, we should use rollup < 0.60.0