Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.0 #6637

Merged
merged 10 commits into from May 8, 2019
Merged

1.5.0 #6637

merged 10 commits into from May 8, 2019

Conversation

cherniavskii
Copy link
Sponsor Collaborator

@cherniavskii cherniavskii commented May 4, 2019

  • Make a new release branch (for example named prepare-X.Y.Z)
  • Make sure you do not have any package.lock.json or yarn.lock locally, since they can potentially make you build with the wrong package versions
  • Update the changelog since last release and commit to the release branch
  • Write a blog post about the new release and put in /docs/_posts and commit to the release branch
  • Bump version number in package.json and commit to master
  • Run npm run release
  • Verify that the release was correctly published to NPM by checking:
  • Update API docs:
    • run npm run docs
    • Copy the built docs from dist/reference-X.Y.Z.html to docs/reference-X.Y.Z.html
    • Update the built docs header to use Jekyll style; see commit 11d716f0964d8bc0d058ca09e9ba8003451b4b8d as reference for the needed changes
    • Commit the new docs to the release branch
  • Update docs/reference.html to redirect to the new version and commit the change to the release branch
  • Update integrity hashes:
    • Checkout the release tag (git checkout vX.Y.Z)
    • Run npm run integrity or simply node ./build/integrity.js if you're not on Debian
    • Copy the hashes and update integrity_hash_css, integrity_hash_source and integrity_hash_uglified in docs/_config.yml; commit changes to the release branch
  • Update link to latest release in docs/download.html, and commit to the release branch
  • Add link to new version reference in docs/reference-versions.html, and commit to the release branch
  • Update latest_leaflet_version in docs/_config.yml and commit to the release branch
  • Update the announcement section in docs/index.html and commit to the release branch
  • If it looks like everything is good at this point, merge the release branch into master
  • Make a new release on Leaflet's GitHub release page with the most important parts of the changelog
  • Post an announcement comment in thread #6295

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The only nit for the changelog is that some items are confusing and only make sense to core contributors — e.g. I'd try to reword items like "Update Polyline's _pxBounds when their stroke weight changes" to what this actually means in practice for users (e.g. "Fixed a bug where mouseover on Canvas-rendered polylines acted inconsistently").

@cherniavskii
Copy link
Sponsor Collaborator Author

@mourner Thanks for your review!
That's good point, I'll update the changelog later

@cherniavskii cherniavskii marked this pull request as ready for review May 8, 2019 07:33
@cherniavskii cherniavskii merged commit e618613 into master May 8, 2019
@cherniavskii cherniavskii deleted the prepare/1.5.0 branch May 8, 2019 07:36
Schleuse pushed a commit to Schleuse/Leaflet that referenced this pull request Dec 3, 2019
* update changelog

* update changelog

* update changelog

* add blog post

* build docs

* update reference

* update integrity hashes

* update download page

* update reference versions

* update announcement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants