Fix: Some translations have been lost in the new version (10.0)

[andrey-helldar]

• Recover localization files from version 9;
• Write and run a script that will find untranslated keys in recovered files and take the translation from files in the locales/{locale}/packages folder;
• Delete the locales/{locale}/packages folders;
• Change the key-value object to an array of values in the source/packages folder;
• Find translatable lines calls in a laravel/framework version 6 project and save them to source/en.json file;
• Find translatable lines calls in a laravel/framework version 7 project and save them to source/en.json file;
• Find translatable lines calls in a laravel/framework version 8 project and save them to source/en.json file;
• Update script app/excludes.php;
• Update script app/keys.php;
• Update script app/packages.php;
• Update script app/status.php;
• Delete script app/split-packages.php;
• Update tests.

[andrey-helldar]

@caouecs, can you linking this PR with #1761? I have no rights to do this.

[luisprmat]

Checking internally Laravel code it seems the only translation that does not match the search patterns that you handle is

• This action is unauthorized.

(because it belongs to an exception message: This action is unauthorized. ) this key is later translated from view src/Illuminate/Foundation/Exceptions/views/403.blade.php with the helper __(...)

__($exception->getMessage() ?: 'Forbidden')

I consider that this key needs to be added manually.

Multi-line keys apparently only exist for notification mails subcopy slot

...
@lang(
    "If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\n".
    'into your web browser:',
    [
        'actionText' => $actionText,
    ]
) <span class="break-all">[{{ $displayableActionUrl }}]({{ $actionUrl }})</span>
...

[andrey-helldar]

@luisprmat, @caouecs, everything is in order with the Russian language. Can you check fr and es?

I grabbed the file from the #1335 (before Jetstream was added), restored the files from version 9.1.2, and ran php app/keys.php.

[sotten]

@andrey-helldar I have checked de.json and de/jetstream.json, the translations are correct. I did not check for missing translation keys.

[andrey-helldar]

@Laravel-Lang/laravel-lang, guys, check this one PR, please.

[luisprmat]

Let's see if I understand your idea.

• In the source folder it only contains arrays with the keys (only keys without translations) used in the {locale}.json base and all packages including repetitions if necessary (for example breeze and jetstream share several keys therefore they appear in both files).
• In locales folder a single file locales/{locale}/{locale}.json with all mixed keys with translations and a unique translation.

I think it is a great idea!! Just a question, Are the keys within the packages still searched automatically?

So I think an excellent job has been done, ¡APPROVED!

[andrey-helldar]

@luisprmat:

In the source folder it only contains arrays with the keys

Yes

In locales folder a single file

Yes

Are the keys within the packages still searched automatically?

Auto-search (these projects do not have json and php files with translations):

• laravel/breeze
• laravel/fortify
• laravel/jetstream

Manually copying files (these projects have json or php files with translations):

• laravel/cashier
• laravel/jetstream
• laravel/fortify
• laravel/nova
• laravel/spark-paddle
• laravel/spark-stripe

[caouecs]

Just some questions on code

[sotten]

@andrey-helldar excellent job! I skimmed de.json and de_CH.json and could not find any errors.
APPROVED

[andrey-helldar]

Just in case, I'll write how I worked with translations:

1. Copied all localization files from version 9;
2. Launched a script that found all json files in the localization folder;
3. The script combined all the keys into one array with the uniqueness check;
4. Saved the resulting array to the {locale}/{locale}.json file;
5. Removed packages folders from localizations.

[caouecs]

I merge this pull request, and I create a v10.1

[caouecs]

thank you

[mohamedsabil83]

Thank you @andrey-helldar and the rest for the great work and suggestions have done.
Also, I apologize for my absence the past few days due to my illness.

[andrey-helldar]

@mohamedsabil83, thank you! I hope you are doing well with your health now.

[mohamedsabil83]

Thank you for asking @andrey-helldar. I am currently recovering and will be back to work soon.