Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mb_strwidth() Passing null to parameter 1 is deprecated #4492 #4493

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

Polfo
Copy link

@Polfo Polfo commented Jul 4, 2022

WHY

BEFORE - What was wrong? What was happening before this PR?

#4492

AFTER - What is happening after this PR?

solved

HOW

How did you achieve that, in technical terms?

?? '' to replace null

Is it a breaking change?

no

How can we test the before & after?

I would be happy to complement a test. I looked at the existing test like tests/Unit/CrudPanel/CrudPanelColumnsTest.php but did not find how to test the blade when null.

@welcome
Copy link

welcome bot commented Jul 4, 2022

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

Verified

This commit was signed with the committer’s verified signature.
promatik António Almeida
@promatik
Copy link
Contributor

Thank you for the PR @Polfo 👌

I have just expanded your fix to the other columns, and an helper that may also raise that deprecated notice.

@promatik promatik changed the title fix [Bug] mb_strwidth(): Passing null to parameter #1 is deprecated #4492 Fix mb_strwidth() Passing null to parameter 1 is deprecated #4492 Jul 14, 2022
@tabacitu tabacitu assigned pxpm and unassigned tabacitu Jul 14, 2022
Copy link
Contributor

@pxpm pxpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pxpm pxpm assigned tabacitu and unassigned pxpm Jul 18, 2022
@tabacitu tabacitu merged commit 6c335a8 into Laravel-Backpack:4.1 Jul 19, 2022
@welcome
Copy link

welcome bot commented Jul 19, 2022

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

  • give your opinion on other Github Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-)
Cheers!

--
Justin Case
The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please apply for free licenses and mention this PR. You scratch my back, I scratch your back. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants