Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "removed v3 config file in order to work with any version of spatie/laravel-backup" #110

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Apr 5, 2022

Reverts #104

That PR should NOT have been merged into the v3 branch... but into master or a new v4 branch. This is the major breaking change in v4, after all.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…patie/laravel-backup"
@tabacitu tabacitu merged commit 2e13e9a into v3 Apr 5, 2022
@tabacitu tabacitu deleted the revert-104-remove-v3-config-file branch April 5, 2022 05:34
@tabacitu tabacitu mentioned this pull request Apr 5, 2022
@tabacitu
Copy link
Member Author

tabacitu commented Apr 5, 2022

Ok... now I don't know who's more stupid. Past me or current me... I can't tell if I was wrong when merging this into v3... or when reverting this just now... @pxpm help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant