Simplify hash/nonce_gen tagging #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need two traits that have almost the same API.
LLFourn
force-pushed
the
simplify_tags
branch
from
4710292
to
250b6e8
Compare
...how can this only be detected now...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddTagandTaggedthat did basically the same thing.AddTagwas used forNonceGens whileTaggedwas used for hashes. Merging them into oneTagtrait seems to have solved more friction than it created and seems to be less confusing.alloceven when we didn't. Fixing this revealed that we were actually usingallocfeatures without intendeding to.NonceRngimplementations forRefCells andMutexs of rngs while I was around in this code.