Clean up feature flags make things compile with alloc and --no-default-features #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLFourn
changed the title
LLFourn
force-pushed
the
clean_up_feature_falgs
branch
from
56f8750
to
f55dd0d
Compare
LLFourn
force-pushed
the
clean_up_feature_falgs
branch
from
f55dd0d
to
15176d8
Compare
And test packages explicitly because cargo test from workspace seems to be broken.
LLFourn
force-pushed
the
clean_up_feature_falgs
branch
3 times, most recently
from
1137edc
to
b57895f
Compare
LLFourn
force-pushed
the
clean_up_feature_falgs
branch
from
b57895f
to
5c01ec4
Compare
|
The original problem seems to be a bug in cargo that I can't find reference to anywhere. The work around is to test each package independently. I've pushed some commits to use the new cargo features available in [dependencies]
secp256kfun = { path = "../secp256kfun", version = "0.7.1", default-features = false }🎉 and that's it! I've managed to re-export Now I think I'll go ahead and try and add some "only if this feature is enabled" doc thingos and that will be it for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
secp256kfundoesn't actually compile with--no-default-features. This is weird because we test it. The problem is that it works at the workspace root but if you cd into the directory and run the same command it breaks. According to rust-lang/cargo#4753 this issue as been fixed ages ago but it's happening for me.So this PR is for investigating this and cleaning up feature flags in general.