Frost and MuSig joint key Point type parameter #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change musig and frost keys to allow for any point type * keygen creates Normal points * signing operations are done with EvenY points
LLFourn
reviewed
Oct 17, 2022
LLFourn
requested changes
Oct 17, 2022
There was a problem hiding this comment.
Merging the two states of the key into one looks good.
- The type parameter should only be set to
Tin one function:gen_nonce_rng.FrostKeyneeds to be passed in here. - Delete the nonce generation stuff from
binonceas the rng sutff supersedes it. - Add a
gen_nonce_rngto theMuSigtype which takes theAggKeyin the same way you did it infrost.
nickfarrow
force-pushed
the
frost-musig-types
branch
from
2c6de42
to
501d8f1
Compare
|
I believe this PR is ready for merge. I think we will leave cloning |
LLFourn
reviewed
Oct 31, 2022
| secret: &Scalar, | ||
| session_id: &[u8], | ||
| public_key: Option<Point<impl Normalized>>, | ||
| // public_key: Option<Point<impl Normalized>>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating #128 minus the cherry-picked commit from #129