Move k256 backend into the crate #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLFourn
force-pushed
the
vendor-k256
branch
3 times, most recently
from
26c172d
to
0636536
Compare
The minimum change possible to remove the dependency. Still a lot of things to clean up.
purge all the old feature flags from the backend.
LLFourn
force-pushed
the
vendor-k256
branch
from
fdba630
to
70be0b9
Compare
Nothing much changed.
LLFourn
force-pushed
the
vendor-k256
branch
from
70be0b9
to
fc66e89
Compare
This was done by pasting the files over the original and looking at what changed and then selectively adding those changes. We're unable to fully update to it because it uses crypto-bigint to do some scalar operations which we can't as a dependency. This commit carefully incorporates the state of the upstream as much as possible. It was extremely tedious work.
LLFourn
force-pushed
the
vendor-k256
branch
from
9e9359c
to
caac95b
Compare
To avoid compiling two functions we do the same thing.
LLFourn
force-pushed
the
vendor-k256
branch
from
9ac0bf9
to
a9a306b
Compare
To make explaining licenses easier.
LLFourn
force-pushed
the
vendor-k256
branch
from
7d8714f
to
de75601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum change possible to remove the dependency. Still a lot of things to clean up.