minimessage: Ignore invalid tags when parsing #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the previous one to emphasize that it throws.
Previously, these would cause a parse error, but they should just be outputted literally
As cursed as it is, it would have been valid before
kezz
approved these changes
Mar 4, 2022
zml2008
reviewed
Mar 5, 2022
...message/src/main/java/net/kyori/adventure/text/minimessage/internal/parser/node/TagNode.java
Outdated
Show resolved
Hide resolved
zml2008
approved these changes
Mar 5, 2022
zml2008
pushed a commit
that referenced
this pull request
Mar 7, 2022
This was referenced Mar 7, 2022
Merged
Closed
Merged
Merged
Merged
Update dependency net.kyori:adventure-text-minimessage to v4.10.1 - autoclosed
Project-Cepi/KStom#97
Closed
This was referenced Mar 7, 2022
Merged
Merged
Merged
build: Update dependency net.kyori:adventure-nbt to v4.9.3
IntellectualSites/FastAsyncWorldEdit#1658
Merged
This was referenced Mar 21, 2022
Closed
1 task
This was referenced Apr 13, 2022
Update dependency net.kyori:adventure-text-minimessage to v4.10.1
eldoriarpg/SchematicBrushReborn#63
Merged
This was referenced May 9, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #717, these would cause a parse error, but they should just be outputted literally, as to not break on arbitrary input
Note: pretty ugly fix, adding a second tag checker helper and using a pretty magical children-traversing method, but i didn't want to resort to a try-catch, please advise if something like that would be better