Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when input contains legacy formatting codes #515

Closed
kezz opened this issue Nov 2, 2021 · 3 comments · Fixed by #662
Closed

Warn when input contains legacy formatting codes #515

kezz opened this issue Nov 2, 2021 · 3 comments · Fixed by #662

Comments

@kezz
Copy link
Member

kezz commented Nov 2, 2021

Perhaps even just throwing an exception would be nice

@Proximyst
Copy link
Member

private static final boolean WARN_WHEN_LEGACY_FORMATTING_DETECTED = Boolean.getBoolean(String.join(".", "net", "kyori", "adventure", "text", "warnWhenLegacyFormattingDetected"));

Isn't this already done?

@kezz
Copy link
Member Author

kezz commented Nov 2, 2021

Yes, but this is disabled by default. MiniMessage could easily have this enabled by default as the reasons why it was disabled by default for the API aren't present when constructing components with MiniMessage.

@MiniDigger
Copy link
Member

should only throw exception in strict mode (if thats still a thing? dont remember)

@kashike kashike transferred this issue from KyoriPowered/adventure-text-minimessage Nov 28, 2021
@zml2008 zml2008 added this to the 4.10.0 milestone Dec 11, 2021
LinoxGH added a commit to LinoxGH/adventure that referenced this issue Jan 11, 2022
@zml2008 zml2008 linked a pull request Feb 28, 2022 that will close this issue
zml2008 pushed a commit to LinoxGH/adventure that referenced this issue Feb 28, 2022
zml2008 pushed a commit to LinoxGH/adventure that referenced this issue Feb 28, 2022
zml2008 pushed a commit to LinoxGH/adventure that referenced this issue Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants