Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footnote support #296

Closed
simblestudios opened this issue Feb 17, 2016 · 10 comments
Closed

footnote support #296

simblestudios opened this issue Feb 17, 2016 · 10 comments

Comments

@simblestudios
Copy link

I'm unable to tell if WeasyPrint is supposed to support footnotes or not (I'm probably missing where it says it doesn't) but if it doesn't support them, then this is a feature request. If it is supposed to support them, then it's a bug.

(weasy)test $ weasyprint --version
WeasyPrint version 0.26
(weasy)test $ weasyprint book.html footy.pdf
Ignored `float: footnote` at 34:11, invalid value.
Invalid or unsupported selector '.fn::footnote-call', Unknown pseudo-element: footnote-call
Invalid or unsupported selector '.fn::footnote-marker', Unknown pseudo-element: footnote-marker
@SimonSapin
Copy link
Member

They’re not supported at the moment. http://weasyprint.org/docs/features/ should be exhaustive. (If it’s not, that’s a documentation bug.)

@simblestudios
Copy link
Author

Thanks for the clarification! I wasn't sure if footnote-call and the other Generated Content stuff was included as supported in this part of the features page:

The following features are supported:
    CSS Colors Level 3 (except the deprecated System Colors)
    **CSS Paged Media (except named pages)**
    ...

Maybe some clarification on that would be useful? I'd be happy to PR an update, but I'm not sure what is / isn't supported as it seems some parts (like string()) are.

Thanks again for the info, and thanks even more for Weasy!

@SimonSapin
Copy link
Member

"CSS Paged Media" in your quote links to https://drafts.csswg.org/css-page-3/ . That’s a different document from https://drafts.csswg.org/css-gcpm/

@simblestudios
Copy link
Author

Understood. But remember, some of your users are dumb people (like me!) who are new to all this stuff and might get confused. ;)

@SimonSapin
Copy link
Member

No worries :) How do you think the docs could be clarified?

@simblestudios
Copy link
Author

Not sure exactly. Perhaps a line about the Generated Content (because you do seem to support some of it, yes?) in the Other CSS Modules section would be helpful. Footnotes are an important feature to some, and if you happen to know it's a Generated Content thing, you can infer it's not supported by omission, but for people just getting into this realm who have no / limited knowledge of the various specs, this might save them from fighting for a while with El Capitan to install only to find no footnotes.

@SimonSapin
Copy link
Member

@liZe, do you wanna rewrite this section? http://weasyprint.org/docs/features/#css-gcpm-bookmarks

@liZe
Copy link
Member

liZe commented Feb 19, 2016

I do! #297

@simblestudios
Copy link
Author

Just saw the updated docs... good stuff!

@liZe
Copy link
Member

liZe commented Feb 23, 2016

I've open #298 about adding the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants