Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml2rfc test regression with 57.0 #1752

Closed
kitterma opened this issue Oct 24, 2022 · 4 comments
Closed

xml2rfc test regression with 57.0 #1752

kitterma opened this issue Oct 24, 2022 · 4 comments

Comments

@kitterma
Copy link
Contributor

Since I upgraded to 57.0, xml2rfc fails its tests. Here's a log (although I don't expect it to help much):

https://ci.debian.net/data/autopkgtest/testing/amd64/x/xml2rfc/27394437/log.gz

It's not clear to me if this is due to an issue in Weasyprint or an error in xml2rfc. I bisected the issue on the Weasyprint side to this commit:

4b447d3

If I add the deleted line of code back in, all the tests pass. I verified that when the tests are running, font is weasyprint.pdf.stream.Font and last_font is None in some cases and both are weasyprint.pdf.stream.Font in others and the conditional for stream.set_font_size is executed, so I'm somewhat mystified how it could go wrong. Any suggestions would be appreciated?

@liZe
Copy link
Member

liZe commented Oct 24, 2022

Hi!

It’s probably a duplicate of fixed #1748. Could you please check that it’s fixed in master?

@kitterma
Copy link
Contributor Author

Yes. Works now. Thanks.

@liZe liZe closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2022
@liZe
Copy link
Member

liZe commented Oct 24, 2022

We’ll release version 57.1 soon.

@kitterma
Copy link
Contributor Author

Excellent news. Thanks.

kesara added a commit to kesara/xml2rfc that referenced this issue Nov 4, 2022
Weasyprint 57.0 introduced a bug that breaks xml2rfc tests.
This is fixed in Weasyprint 57.1.
See Kozea/WeasyPrint#1752
kesara added a commit to ietf-tools/xml2rfc that referenced this issue Nov 7, 2022
Weasyprint 57.0 introduced a bug that breaks xml2rfc tests.
This is fixed in Weasyprint 57.1.
See Kozea/WeasyPrint#1752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants