Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji Support seems broken in the latest WeasyPrint #1506

Closed
oz123 opened this issue Nov 26, 2021 · 2 comments
Closed

Emoji Support seems broken in the latest WeasyPrint #1506

oz123 opened this issue Nov 26, 2021 · 2 comments

Comments

@oz123
Copy link

oz123 commented Nov 26, 2021

I am trying to create a PDF with the following content:

$ minikube node add -p devopscon
😄  Adding node m02 to cluster devopscon
❗  Cluster was created without any CNI, adding a node to it might cause broken networking.
👍  Starting worker node devopscon-m02 in cluster devopscon
🔥  Creating kvm2 VM (CPUs=2, Memory=2848MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.22.3 on Docker 20.10.8 ...
🔎  Verifying Kubernetes components...
🏄  Successfully added m02 to devopscon!

I document is built with:

easyprint -e utf-8 _build/singlehtml/index.html "_build/output.pdf"

The header contains:

<!DOCTYPE html>

<html>
  <head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <meta name="generator" content="Docutils 0.17.1: http://docutils.sourceforge.net/" />
...

The emojis are shown in this version:

 $ weasyprint --version
WeasyPrint version 52.5

The emojis are not showing with the latest version,

$ weasyprint --version
WeasyPrint version 53.4
@oz123
Copy link
Author

oz123 commented Nov 26, 2021

Woot! This works! On the master branch, and it look much better than the ugly png based rendered emojis !!! 👏

@oz123 oz123 closed this as completed Nov 26, 2021
@liZe
Copy link
Member

liZe commented Nov 28, 2021

Woot! This works! On the master branch, and it look much better than the ugly png based rendered emojis !!! 👏

Yes, it’s been fixed by #1434, and we now handle SVG emojis that look better than raster ones 😁.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liZe @oz123