Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print-css.rocks renderings with latest beta #1400

Closed
zopyx opened this issue Jul 20, 2021 · 2 comments
Closed

print-css.rocks renderings with latest beta #1400

zopyx opened this issue Jul 20, 2021 · 2 comments
Labels
bug Existing features not working as expected

Comments

@zopyx
Copy link

zopyx commented Jul 20, 2021

Hi there,

I am currently preparing a new print-css.rocks release. A few renderings appear weird with WP 53.0b2

https://beta.print-css.rocks/lesson/lesson-fonts-emoji

https://beta.print-css.rocks/lesson/lesson-images

https://beta.print-css.rocks/lesson/lesson-pdf-links

https://beta.print-css.rocks/lesson/lesson-cross-references
liZe added a commit that referenced this issue Jul 23, 2021
@liZe
Simplify when begin/end text tags are inserted
e30907c 
The previous behaviour was introduced by 603ee26 as an optimization.
Unfortunately, it was not correct because text decoration can’t be drawn inside
the begin/end text tags. Generated PDF files were incorrect, leading to buggy
rendering by Ghostscript.

Related to #1400.
@liZe
Copy link
Member

liZe commented Jul 23, 2021

Thanks for the bug report.

e30907c fixes pdf-links and cross-references.

Colored emojis are not supported yet with pydyf. Emojis work with common monochrome fonts, but they’re broken as soon as a font with colored emojis is installed.

The problem with SVG is unknown and has to be fixed.

@liZe liZe added the bug Existing features not working as expected label Jul 23, 2021
liZe added a commit that referenced this issue Jul 23, 2021
@liZe
Fix translation when viewBox’s origin is not 0,0
6417023 
Related to #1400.
@liZe
Copy link
Member

liZe commented Jul 28, 2021

lesson-images is now fixed.

Well… Honestly, it’s not fully supported (see the green gradient), because of our poor support of SVG in 53. It will be better in future versions. At least, the image is displayed and doesn’t look bad.

We have open an issue for emojis (#1406) and everything else is fixed or tracked, let’s close this issue.

Thanks again for your report. We’ll definitely spend some time on the failing examples (we’d love to display the deer correctly ❤️).

@liZe liZe closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zopyx @liZe