Gradle 7.4.2, Kotlin 1.6.21 and other plugin updates #3281
Merged
+72
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
May 16, 2022
There was a problem hiding this comment.
I see that the build consistently fails on our CI (e.g. https://teamcity.jetbrains.com/viewLog.html?buildTypeId=KotlinTools_KotlinxCoroutines_Build&buildId=3854604&tab=buildLog&logTab=tree&filter=debug&expand=all&_focus=961):
Script '/mnt/agent/work/44ec6e850d5c63f0/gradle/test-mocha-js.gradle' line: 12
Could you please take a look and ensure that ./gradlew build passes?
Meanwhile I'll handle Dokka
wojtek-kalicinski
force-pushed
the
gradle-7.4.2
branch
from
b00aefd to
7a0d316
Compare
|
There was a code path that was only accessed with -Pteamcity set that I didn't notice. Fixed, can you try it now? |
qwwdfsad
approved these changes
May 17, 2022
| @@ -56,6 +57,11 @@ fun configureMavenPublication(rh: RepositoryHandler, project: Project) { | |||
| password = project.getSensitiveProperty("libs.sonatype.password") | |||
| } | |||
| } | |||
|
|
|||
| // Something that's easy to "clean" for development, not mavenLocal | |||
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to Gradle 7.4.2 also includes updating or removing plugins that were outdated or incompatible with Gradle 7.x
Kotlin 1.6.21 update is not required but bumping anyway since tests pass.
One difference that I noticed is that dokka now generates absolute paths for links, and not
../../, if this is a problem it's something that should be looked into../gradlew buildpasses, and I also verified (more or less) that all files are generated in the right paths in the maven publication.