Fix limitedParallelism implementation on K/N #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial implementation predates new memory model and was never working on it Fixes #3223
| } | ||
| val j2 = launch(view2) { j1.cancel() } | ||
| joinAll(j1, j2) | ||
| } |
There was a problem hiding this comment.
Suggestion: move this test to the JS source-set, and move the testTaskFairness test from the JVM source-set to concurrent. This way, there will still be two versions of the test, but each one will be the most specific one for each target.
There was a problem hiding this comment.
Left this one as is to still have common coverage and added test with newSingleThreadContext to concurrent source set. Juggled with names a bit as well
There was a problem hiding this comment.
Ok, but I think having this test looks confusing. Maybe add a comment?
qwwdfsad
force-pushed
the
fix-limited-parallelism
branch
from
3ddac07
to
135a3e6
Compare
dkhalanskyjb
approved these changes
Mar 31, 2022
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
The initial implementation predates new memory model and was never working on it Fixes Kotlin#3223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation predates new memory model and was never working on it
Fixes #3223