Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail-fast in emitAll implementation from onCompletion #2700

Merged
merged 1 commit into from May 13, 2021

Conversation

qwwdfsad
Copy link
Member

It is helpful to prevent bugs like KT-46013 and potential deadlocks or delayed cancellations

It is helpful to prevent bugs like KT-46013 and potential deadlocks or delayed cancellations
@qwwdfsad qwwdfsad requested a review from elizarov May 13, 2021 08:50
@qwwdfsad
Copy link
Member Author

Also likely fixes #2669

Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Great solution!

@qwwdfsad qwwdfsad merged commit a3b6043 into develop May 13, 2021
@qwwdfsad qwwdfsad deleted the on-completion-emitall branch May 14, 2021 14:49
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
It is helpful to prevent bugs like KT-46013 and potential deadlocks or delayed cancellations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants