Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cancellation exception from standard library in Kotlin/JS and K/N #2638

Merged
merged 2 commits into from Apr 21, 2021
Merged

Use cancellation exception from standard library in Kotlin/JS and K/N #2638

merged 2 commits into from Apr 21, 2021

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Apr 8, 2021 

* On JVM it uses java.util.concurrent.CancellationException, same as stdlib declaration
* Fully backward compatible for JVM, Native-friendly for Obj-C interop

@qwwdfsad
Use cancellation exception from standard library in Kotlin/JS and K/N
518e39d 
    * On JVM it uses java.util.concurrent.CancellationException, same as stdlib declaration
    * Fully backward compatible for JVM, Native-friendly for Obj-C interop
@qwwdfsad qwwdfsad requested a review from elizarov April 9, 2021 14:17
elizarov
elizarov approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

kotlinx-coroutines-core/native/src/Exceptions.kt Show resolved Hide resolved
@qwwdfsad qwwdfsad merged commit 44ebdef into develop Apr 21, 2021
@qwwdfsad qwwdfsad deleted the cancellation-exception branch April 21, 2021 16:01
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Use cancellation exception from standard library in Kotlin/JS and K/N (…
0d2a87b 
…Kotlin#2638)


* On JVM it uses java.util.concurrent.CancellationException, same as stdlib declaration
* Fully backwards compatible for JVM, Native-friendly for Obj-C interop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwwdfsad @elizarov