Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premain-Class missing in 1.4.3 causing debug failures in IntelliJ #2619

Closed
deweyx opened this issue Mar 30, 2021 · 1 comment
Closed

Premain-Class missing in 1.4.3 causing debug failures in IntelliJ #2619

deweyx opened this issue Mar 30, 2021 · 1 comment
Assignees
Labels

Comments

@deweyx
Copy link

deweyx commented Mar 30, 2021

Related to KTIJ-5659, the 1.4.3 build of kotlinx-coroutines-core does not include Premain-Class in the MANIFEST.MF, nor the AgentPremain.class file. Those do exist in kotlinx-coroutines-core-jvm-1.4.3.jar.

This is causing failures when debugging unit tests in IntelliJ, which attempts to reference -javaagent:.../kotlinx-coroutines-core-1.4.3.jar if you don't include a dependency on kotlinx-coroutines-core-jvm-1.4.3.jar (or if kotlinx-coroutines-core-1.4.3.jar is before kotlinx-coroutines-core-jvm in your effective pom.xml for a maven project).

@qwwdfsad qwwdfsad added the bug label Apr 6, 2021
@qwwdfsad
Copy link
Member

qwwdfsad commented Apr 6, 2021

Thanks for the report and investigation in the ticket!

While we are deciding, where exactly this bug belongs, I'll try to workaround it on coroutines side

@qwwdfsad qwwdfsad self-assigned this Apr 6, 2021
qwwdfsad added a commit that referenced this issue Apr 6, 2021
…routines-core

    * It fixes IDEA issue that was introduced in coroutines 1.4.3 where we switched to Kotlin 1.4.30 and stopped producing root artifact with JVM classes
    * It simplifies manual -javaagent specification for end-users who shouldn't even be aware of kotlinx-coroutines-core-jvm.jar

Fixes #2619
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this issue Sep 14, 2022
…routines-core (Kotlin#2632)

* It fixes IDEA issue that was introduced in coroutines 1.4.3 where we switched to Kotlin 1.4.30 and stopped producing root artifact with JVM classes
    * It simplifies manual -javaagent specification for end-users who shouldn't even be aware of kotlinx-coroutines-core-jvm.jar

Fixes Kotlin#2619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants