Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the reactive integrations #2617

Merged
merged 3 commits into from Apr 22, 2021
Merged

Fixes for the reactive integrations #2617

merged 3 commits into from Apr 22, 2021

Conversation

dkhalanskyjb
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb commented Mar 30, 2021

Improves documentation, adds a couple of new tests.

* Fixed the broken links in the docs
* Some new links are added to the docs
* More detailed descriptions of error handling for some methods
* Small grammar fixes
* Code formatting changes
TODO: if they are accepted, maybe clone to the jdk9 module
Add more tests for `collect { }` methods on reactive publishers.
@dkhalanskyjb dkhalanskyjb changed the title [DRAFT] Fixes for the reactive integrations Fixes for the reactive integrations Apr 21, 2021
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dkhalanskyjb dkhalanskyjb merged commit 05d3018 into develop Apr 22, 2021
@dkhalanskyjb dkhalanskyjb deleted the reactive-fixes branch April 22, 2021 11:41
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
Reworked the comments, added new tests.
Fixed a bug where `Maybe.collect()` would hang on success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants