Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TimeSource to SchedulerTimeSource due to KT-42625 #2537

Merged
merged 1 commit into from Feb 16, 2021

Conversation

qwwdfsad
Copy link
Member

No description provided.

Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qwwdfsad qwwdfsad merged commit 01dcfe5 into develop Feb 16, 2021
@qwwdfsad qwwdfsad deleted the rename-timesource branch February 16, 2021 08:33
@gmk57
Copy link

gmk57 commented May 7, 2021

This error happens again with coroutines 1.5.0-RC. Will this fix be merged into 1.5.* branches?

@elizarov
Copy link
Contributor

elizarov commented May 9, 2021

As far as I can see, it has been renamed in both 1.4.3 and 1.5.0-RC. Are you sure you still experience this problem with those versions?

@gmk57
Copy link

gmk57 commented May 9, 2021

Yes, for example this code with wildcard imports (import kotlinx.coroutines.* + import kotlin.time.*) does not compile: Unresolved reference: TimeSource

I've double-checked and this happens with both 1.4.3 and 1.5.0-RC. So the 1.4.3 release notes probably relate to something else: they mention "internal class TimeSource" while I see an internal interface. Here it is in the source code for 1.4.3 and 1.5.0-RC.

UPDATE: It occurred to me to actually look at the pull request we're discussing. ;)) If I understand correctly, it renames kotlinx.coroutines.scheduling.TimeSource, not kotlinx.coroutines.TimeSource mentioned in YouTrack issues.

@elizarov
Copy link
Contributor

elizarov commented May 9, 2021

Thanks. Created #2691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants