Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not initialize CoroutineExceptionHandler in Job <clinit> #2513

Merged
merged 1 commit into from Mar 22, 2021
Merged

Do not initialize CoroutineExceptionHandler in Job <clinit> #2513

merged 1 commit into from Mar 22, 2021

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Feb 1, 2021 

* It slightly cuts down startup time
* It simplifies the code in general
* It do not serve its purpose, coroutines are already protected from StackOverflowError with nested event-loops where applicable

@qwwdfsad
Do not initialize CoroutineExceptionHandler in Job <clinit>
3d9d8b0 
    * It slightly cuts down startup time
    * It simplifies the code in general
    * It do not serve its purpose, coroutines are already protected from StackOverflowError with nested event-loops where applicable
elizarov
elizarov approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@qwwdfsad qwwdfsad merged commit 6f13927 into develop Mar 22, 2021
@qwwdfsad qwwdfsad deleted the job-init branch March 22, 2021 12:09
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Do not initialize CoroutineExceptionHandler in Job <clinit> (Kotlin#2513
fad9458 
)

* It slightly cuts down startup time
    * It simplifies the code in general
    * It do not serve its purpose, coroutines are already protected from StackOverflowError with nested event-loops where applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwwdfsad @elizarov