Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to reactor 3.4.0 #2432

Closed
piyushmor opened this issue Dec 5, 2020 · 6 comments
Closed

Upgrade to reactor 3.4.0 #2432

piyushmor opened this issue Dec 5, 2020 · 6 comments

Comments

@piyushmor
Copy link

Spring Boot 2.4.0 uses project reactor version 3.4.0. We need to upgrade kotlinx-coroutines-reactor to use 3.4.0 version of project reactor for it to work with the new version of Spring Boot.

@qwwdfsad
Copy link
Member

qwwdfsad commented Dec 8, 2020

Unfortunately, we cannot do it right now because we are targeting Java 6, while Reactor 3.4.1 targets Java 8.
So we would like to postpone this update until we completely migrate to Java 8.

@sdeleuze do you have any objections against coroutines staying on 3.2.5.RELEASE?

@piyushmor
Copy link
Author

hope the cost is worth it, we will not be able to support Spring Boot 2 then. Especially because there are a lot of breaking changes in reactor 3.4.0

@sdeleuze
Copy link
Contributor

I don't think we have changed the Java requirements, as far as I remember Reactor is Java 8+ from the beginning so IMO it should be possible to do the upgrade on kotlinx-coroutines-reactor unless I missed something.

@qwwdfsad
Copy link
Member

Aha, thanks! It seems like we were compiling this module against Java 6 and reactor didn't have the corresponding Gradle metadata prior to 3.4.1. We'll update it in the next release

@piyushmor
Copy link
Author

I am not sure if this does not warrant an early release

@qwwdfsad
Copy link
Member

qwwdfsad commented Mar 2, 2021

Fixed with #2458

@qwwdfsad qwwdfsad closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants