Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancellation support for Mutex when lock becomes available between tryLock and suspending. #2390

Closed
wants to merge 1 commit into from

Conversation

Tilps
Copy link
Contributor

@Tilps Tilps commented Nov 16, 2020

A synchronous call to continuation.resume in suspendLock doesn't preclude a cancellation race, so it needs the same care as during the passing of ownership that takes place in unlock.
Fixes #2380

@qwwdfsad qwwdfsad self-requested a review November 16, 2020 18:09
qwwdfsad added a commit that referenced this pull request Nov 17, 2020
@qwwdfsad
Copy link
Member

Thanks! Opened #2396 with semaphore fix and better solution, will merge it instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants