Add lint warnings on SharedFlow operations that never complete #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavonnet
reviewed
Nov 9, 2020
qwwdfsad
reviewed
Nov 12, 2020
| message = "SharedFlow never completes, so this terminal operation never completes.", | ||
| level = DeprecationLevel.WARNING, | ||
| replaceWith = ReplaceWith("awaitCancellation()") |
There was a problem hiding this comment.
awaitCancellation seems to be unintended
There was a problem hiding this comment.
I really cannot figure out a better replacement. We can leave it without a replacement, though.
qwwdfsad
approved these changes
Nov 16, 2020
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2340
Fixes #2368