Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SharedFlow with replay for subscribers working at different speed #2325

Merged
merged 1 commit into from Oct 26, 2020
Merged

Fix SharedFlow with replay for subscribers working at different speed #2325

merged 1 commit into from Oct 26, 2020

Conversation

elizarov
Copy link
Contributor

Problematic scenario:

  • Emitter suspends because there is a slow subscriber
  • Fast subscriber collects all the values and suspend
  • Slow subscriber resumes, collects value, causes emitter to be resume
  • Fast subscribers must be resumed in this case, too

Fixes #2320

@elizarov
Fix SharedFlow with replay for subscribers working at different speed
e407954 
Problematic scenario:
* Emitter suspends because there is a slow subscriber
* Fast subscriber collects all the values and suspend
* Slow subscriber resumes, collects value, causes emitter to be resume
* Fast subscribers must be resumed in this case, too

Fixes #2320
@elizarov elizarov merged commit 53f007f into develop Oct 26, 2020
@elizarov elizarov deleted the shared-flow-replay-resumes branch October 26, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
For 1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elizarov @qwwdfsad