1.4.0 experimentality #2316
Merged
1.4.0 experimentality #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removing them, warning was not strict enough
* CoroutineDispatcher.invoke
* ReceiveChannel.consume and ReceiveChannel.consumeEach
* Flow core operators: onStart, onCompletion, onEmpty
* CompletableDeferred.completeWith
* awaitCancellation
* Add experimentality notes where applicable
qwwdfsad
force-pushed
the
1.4.0-experimentality
branch
from
397a080
to
21d82f3
Compare
qwwdfsad
commented
Oct 19, 2020
|
Please, don't stabilize |
elizarov
approved these changes
Oct 23, 2020
elizarov
suggested changes
Oct 23, 2020
ferinagy
reviewed
Oct 27, 2020
| @@ -27,7 +27,7 @@ internal expect fun assert(value: () -> Boolean) | |||
| * Copy mechanism is used only on JVM, but it might be convenient to implement it in common exceptions, | |||
| * so on JVM their stacktraces will be properly recovered. | |||
| */ | |||
| @ExperimentalCoroutinesApi | |||
| @ExperimentalCoroutinesApi // Since 1.2.0, no ETA on stability | |||
There was a problem hiding this comment.
What is needed for CopyableThrowable to become stable? Is there any issue to watch? Can we help somehow?
This came to my attention, because Retrofit now produces not very helpful stacktraces from suspending calls and the corresponding fix is blocked because this is experimental: square/retrofit#3474
There was a problem hiding this comment.
The best way is to let us know and file an issue. Filed #2367
10 tasks
ParaskP7
added a commit
to ParaskP7/sample-code-movies
that referenced
this pull request
Nov 9, 2020
A notable addition to this release is the below: "StateFlow, SharedFlow and corresponding operators are promoted to stable API (Kotlin/kotlinx.coroutines#2316)."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matters to discuss/TODO list:
StateFlow,ShareFlowand co. Let's lift experimentality right now?callbackFlow/channelFlow. TBD, but seems like it's time to stabilize it(Conflated)BroadcasChannel. It's definitely time to mark them asObsolete, but if we agree on p. 1, let's deprecate it with a warning for future removal (hiding, at least).WARNINGin 1.5.0 when shared/state flows are well-used and widespread