Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoroutinesTimeout replacement for JUnit 5 #2197

Closed
asarkar opened this issue Aug 14, 2020 · 4 comments
Closed

CoroutinesTimeout replacement for JUnit 5 #2197

asarkar opened this issue Aug 14, 2020 · 4 comments
Assignees

Comments

@asarkar
Copy link

asarkar commented Aug 14, 2020

https://github.com/asarkar/coroutines-test

@dkhalanskyjb
Copy link
Collaborator

Thank you, this is a nice idea! There is now a PR for this, #2402.

@asarkar
Copy link
Author

asarkar commented Nov 24, 2020

The idea wasn’t to lift my code and make a PR, but to use it as is instead.

@dkhalanskyjb
Copy link
Collaborator

dkhalanskyjb commented Nov 24, 2020

The proposed implementation was written independently from yours and is different in some significant ways. (Though I did look through your code initially!)

@qwwdfsad
Copy link
Member

Fixed in 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants