Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler: Avoid unnecessary work signalling in LimitingDispatcher #1704

Closed
qwwdfsad opened this issue Dec 12, 2019 · 0 comments
Closed

Scheduler: Avoid unnecessary work signalling in LimitingDispatcher #1704

qwwdfsad opened this issue Dec 12, 2019 · 0 comments
Assignees
@qwwdfsad
Labels
performance

Comments

@qwwdfsad
Copy link
Member

To avoid liveness problems, at the end of each "limited" we double-check the queue and dispatch any new tasks from it.
At this point, a scheduler is not aware of the fact that thread it effectively free and issues one more unnecessary thread to help.
@qwwdfsad qwwdfsad self-assigned this Dec 12, 2019
@qwwdfsad qwwdfsad changed the title Avoid unnecessary work signalling in LimitingDispatcher Scheduler: Avoid unnecessary work signalling in LimitingDispatcher Dec 12, 2019
qwwdfsad added a commit that referenced this issue Dec 20, 2019
@qwwdfsad
Do not request additional worker from 'yield' calls and during post-e…
1b8cf6d 
…xecution phase in LimitingDispatcher

Fixes #1704
Fixes #1706
@qwwdfsad qwwdfsad mentioned this issue Dec 20, 2019
Merged
qwwdfsad added a commit that referenced this issue Dec 20, 2019
@qwwdfsad
Do not request additional worker from 'yield' calls and during post-e…
4e19954 
…xecution phase in LimitingDispatcher

Fixes #1704
Fixes #1706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qwwdfsad