Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kotlin.time.Duration overloads for delay in common #1402

Closed
JakeWharton opened this issue Aug 1, 2019 · 3 comments
Closed

kotlin.time.Duration overloads for delay in common #1402

JakeWharton opened this issue Aug 1, 2019 · 3 comments
Labels
enhancement

Comments

@JakeWharton
Copy link
Contributor

No description provided.

@JakeWharton
Copy link
Contributor Author

JakeWharton commented Aug 1, 2019 •
edited

I would also consider deprecating delay(long) with a replacement of delay(value.milliseconds) (once kotlin.time.Duration is stable).

fvasco added a commit to fvasco/kotlinx.coroutines that referenced this issue Feb 16, 2020
@fvasco
kotlin.time.Duration support
ff9d472 
Fixes Kotlin#1402
@fvasco fvasco mentioned this issue Feb 16, 2020
Closed
fvasco added a commit to fvasco/kotlinx.coroutines that referenced this issue Feb 17, 2020
@fvasco
kotlin.time.Duration support
ab31438 
Fixes Kotlin#1402
fvasco added a commit to fvasco/kotlinx.coroutines that referenced this issue Feb 17, 2020
@fvasco
kotlin.time.Duration support
90e3285 
Fixes Kotlin#1402
fvasco added a commit to fvasco/kotlinx.coroutines that referenced this issue Feb 18, 2020
@fvasco
kotlin.time.Duration support
7f8594c 
Fixes Kotlin#1402
fvasco added a commit to fvasco/kotlinx.coroutines that referenced this issue Feb 20, 2020
@fvasco
kotlin.time.Duration support
70eb3df 
Fixes Kotlin#1402
elizarov pushed a commit that referenced this issue Mar 13, 2020
@fvasco @elizarov
kotlin.time.Duration support
cce57c9 
Fixes #1402
@hfhbd
Copy link
Contributor

hfhbd commented Sep 12, 2022

Any plans to deprecate delay(long) and other timeMillis: Long parameters in favor of Duration parameter? It is stable since Kotlin 1.6 and coroutines 1.7 allows breaking changes.
Do you accept such PR?

@qwwdfsad
Copy link
Member

We do not have such plans yet, though it is a good idea not to introduce new API that relies on long millis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JakeWharton @elizarov @qwwdfsad @hfhbd