Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add CoroutineScope.asScheduler and CoroutineDispatcher.asScheduler to kotlinx-coroutines-rx2 #1024

Closed
Guang1234567 opened this issue Mar 3, 2019 · 5 comments

Comments

@Guang1234567
Copy link

Guang1234567 commented Mar 3, 2019

Hello dev:

Could you add CoroutineScope.asScheduler and CoroutineDispatcher.asScheduler function that
let using coroutine in rxjava is possible. Thx.

kotlinx-coroutines-rx2 is only support using rxjava in coroutine now.

@JakeWharton
Copy link
Contributor

Dupe of #968?

@Guang1234567
Copy link
Author

Guang1234567 commented Mar 4, 2019

@JakeWharton

Yes, #968 already has a demo that implement CoroutineDispatcher.asScheduler, nice!

but CoroutineScope.asScheduler?

In addition, CoroutineDispatcher.asScheduler in #968 under unit-test maybe more better.

@qwwdfsad
Copy link
Member

qwwdfsad commented Mar 4, 2019

CoroutineScope.asScheduler

Do you mean just a shorthand for extracting dispatcher from a scope and calling asScheduler or a more complex semantics?

@Guang1234567
Copy link
Author

@qwwdfsad
more complex semantics. see #968

@qwwdfsad
Copy link
Member

qwwdfsad commented Mar 4, 2019

Ok, let's keep track there, will close this as duplicate

@qwwdfsad qwwdfsad closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants