Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow/fix aggregation includedBuilds #598

Closed
gmazzo opened this issue Apr 18, 2024 · 3 comments
Closed

Allow/fix aggregation includedBuilds #598

gmazzo opened this issue Apr 18, 2024 · 3 comments
Assignees
Labels
Feature Feature request issue type S: untriaged Status: issue reported but unprocessed

Comments

@gmazzo
Copy link

gmazzo commented Apr 18, 2024

What is your use-case and why do you need this feature?
kover integrates with Gradle's dependency resolution system by exposing a kover configuration to aggregate projects

As includedBuilds by convention exposes a dependency coordinate (implicit dependencySubstitution), declaring it as a kover dependency is expected to aggregate the child build into the main report.

dependencies {
    kover(":build-logic")
}

This setup does not break the build, the correct koverArtifact[TOTAL] variant is resolved for the included build, but the report does not aggregate it.
image
https://scans.gradle.com/s/2nb3nedv4ntsm/dependencies?focusedDependency=WzAsMCwyLFswLDAsWzJdXV0&toggled=W1swXSxbMCwwXV0

Running ./gradlew :koverHtmlReport produces a report only containing main build modules:
image

While running ./gradlew :build-logic:koverHtmlReport, is correctly computing the build-logic modules (some now not aggregated in the root one):
image

Describe the solution you'd like
Included Builds should be transparently resolved as any other kover dependency and included in the aggregated report. Variants are there, it's seems to a matter of the internal plugin resolution strategy.

@gmazzo gmazzo added Feature Feature request issue type S: untriaged Status: issue reported but unprocessed labels Apr 18, 2024
@shanshin
Copy link
Collaborator

shanshin commented Apr 23, 2024

Thanks for report!
Unfortunately, Composite Builds are not supported at the moment, there are a number of technical limitations why it does not work in its current form.

@shanshin
Copy link
Collaborator

A task has already been opened to design support for such types of builds.

@shanshin
Copy link
Collaborator

Closed as a duplicate of #487

@shanshin shanshin closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request issue type S: untriaged Status: issue reported but unprocessed
Projects
None yet
Development

No branches or pull requests

2 participants