Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K2] Different PageId in K1 and K2 for nested classes #3388

Closed
atyrin opened this issue Nov 30, 2023 · 5 comments · Fixed by #3564
Closed

[K2] Different PageId in K1 and K2 for nested classes #3388

atyrin opened this issue Nov 30, 2023 · 5 comments · Fixed by #3564
Assignees
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Milestone

Comments

@atyrin
Copy link
Contributor

atyrin commented Nov 30, 2023

So far, I have two samples for the change with no visible side effects.

For nested classes

class Parent{
    class Nested
}

K1: pageids="module::/Parent.Nested/Nested/#/PointingToDeclaration//-1486420497"
K2: pageids="module::/Parent.Nested/Parent.Nested/#/PointingToDeclaration//-1486420497"

For vararg arguments

fun withVararg(i: Int, vararg s: String){}

K1: pageids="module:://withVararg/#kotlin.Int#kotlin.Array[kotlin.String]/PointingToDeclaration//-1486420497"
K2: pageids="module:://withVararg/#kotlin.Int#kotlin.String/PointingToDeclaration//-1486420497"

Installation

  • Dokka version: 1.9.20

Parent: #3328

@atyrin atyrin added bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 labels Nov 30, 2023
@vmishenev
Copy link
Member

For vararg arguments

this can affect #2881

@vmishenev
Copy link
Member

vmishenev commented Dec 11, 2023

Both cases are on Dokka's side.

For vararg arguments

Need to ask Analysis API team about String is the expected type here instead of Array<String>

@vmishenev
Copy link
Member

@IgnatBeresnev
Copy link
Member

Best case scenario is that it's fixed in Analysis API, but we can add a local workaround.

@IgnatBeresnev IgnatBeresnev added the upstream bug An issue that appears due to an upstream dependency bug, such as kotlin-compiler label Dec 15, 2023
@vmishenev vmishenev self-assigned this Feb 18, 2024
@IgnatBeresnev IgnatBeresnev removed the upstream bug An issue that appears due to an upstream dependency bug, such as kotlin-compiler label Apr 5, 2024
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Apr 8, 2024

It was decided to extract the case with varargs into a separate issue (#3558) because it is tricker to fix.

This issue should focus on fixing it for nested classes, which should be fairly easy.

@IgnatBeresnev IgnatBeresnev changed the title [K2] Different PageId for the same code in K1 and K2 [K2] Different PageId in K1 and K2 for nested classes Apr 9, 2024
@whyoleg whyoleg self-assigned this Apr 12, 2024
@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants