Update prism.js to match new webhelp highlight colors
#2670
Conversation
| @@ -792,7 +800,6 @@ open class HtmlRenderer( | |||
| TextStyle.Strong -> strong { body() } | |||
| TextStyle.Var -> htmlVar { body() } | |||
| TextStyle.Underlined -> underline { body() } | |||
| is TokenStyle -> span("token " + styleToApply.toString().toLowerCase()) { body() } | |||
There was a problem hiding this comment.
Previously, if a text element had >2 TokenStyle styles, it was rendered as
span("token first") {
span("token second") {
text
}
}
|
JFYI: For some reason the new version of Unable to reproduce it on their playground, so maybe it's a bug of Dokka (incorrect line breaks or something) - needs to be investigated furtner. It can be postponed, so I downgraded it to the version that we had before that.
|
I suppose you have not copied this hook. |
| @@ -71,9 +71,10 @@ class HighlightingTest : BaseAbstractTest() { | |||
| assertTrue(children?.get(it.first)?.style?.contains(it.second) == true) | |||
| val annotation = children?.first()?.children?.first() | |||
|
|
|||
| assertTrue(annotation?.children?.get(0)?.style?.contains(TokenStyle.Annotation) == true) | |||
| assertTrue(annotation?.children?.get(1)?.children?.first()?.style?.contains(TokenStyle.Annotation) == true) | |||
| val annotationStyles = setOf(TokenStyle.Annotation, TokenStyle.Builtin) | |||
There was a problem hiding this comment.
What does TokenStyle.Builtin mean?
I am not sure the output-specific problem should be fixed here, in the content model rather than in the render stage.
There was a problem hiding this comment.
What does TokenStyle.Builtin mean?
It's a good question, you were the one that added the type :) It was already in Public API, so I just used it.
I am not sure the output-specific problem should be fixed here, in the content model rather than in the render stage.
Sure, I can fix it for html-only, but let's then delete TokenStyle.Builtin entry so there's no confusion?
There was a problem hiding this comment.
It's a good question, you were the one that added the type :) It was already in Public API, so I just used it.
I hoped somebody tells me what it means)
You can remove it since it is not used anywhere.
Revert some of the older unnecessary changes
|
No description provided.