Add hotkey for opening search dialog #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an issue, that the hotkey will be triggered even if the key combination is a subset of another key combination (e.g. |
IgnatBeresnev
approved these changes
Aug 24, 2022
vmishenev
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
Cmd + K/Ctrl + Khotkey for opening the search window.Meta key
Cmd/Ctrldepends on OS. For macOS --Cmd, for every other --Ctrl.The search button have a tooltip with the name of key combination. The tooltip appears after 500 ms on mouse over.
The combination prevents default hotkey actions like the kotlinlang.org or github.com behave. E.g. the
Cmd+Kcombination is default option to focus on the omnibox in Firefox.Tested on Chrome/Filefox/Safary on macOS, on Edge/Firefox on Windows
Fix #2265