Display inherited extensions #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
force-pushed
the
display-inherited-extensions
branch
from
1cb34ac
to
c934bdb
Compare
Closed
There was a problem hiding this comment.
👍 well done!
We have a configuration property suppressInheritedMembers - I wonder if collecting inherited extensions should depend on it?
As far as I understand, one of the big reasons to suppress inherited members is because extending Android components adds a lot of them, and user-defined members are easily lost among it in documentation, which is not always desirable. If this could be tested on some android library, it'd be great to see the impact
plugins/base/src/main/kotlin/transformers/documentables/utils/ClassGraphBuilder.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/transformers/documentables/utils/ClassGraphBuilder.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/transformers/documentables/utils/ClassGraphBuilder.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/transformers/documentables/utils/ClassGraphBuilder.kt
Outdated
Show resolved
Hide resolved
vmishenev
force-pushed
the
display-inherited-extensions
branch
from
2bd74f5
to
fecc72d
Compare
IgnatBeresnev
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.