Fix generic types caching #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
force-pushed
the
fix-flaky-dri-of-generic-types
branch
from
e2531f2
to
7a8647c
Compare
IgnatBeresnev
approved these changes
Aug 12, 2022
| ) | ||
|
|
||
| else -> { | ||
| // cache types that has no annotation and no type parameter |
There was a problem hiding this comment.
Side note: this comments explains the code, but doesn't explain the intention behind it, so it's not really clear why we can't cache type parameters. Describing a use case where this can hurt would be nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It caused flaky generation of type links for generic type params (#2596)