Do not render platform tabs for common-only content #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
commented
Aug 8, 2022
IgnatBeresnev
commented
Aug 8, 2022
Comment on lines
+956
to
+957
| .table-row .platform-hinted .sourceset-dependent-content .brief, | ||
| .table-row .platform-hinted .sourceset-dependent-content .inline-comment { |
There was a problem hiding this comment.
Because there's no tabs, now content is rendered the same way as for single platform projects, and there's currently a visual problem - no padding between paragraphs. See this page for instance
This should solve it for both single and multi platform pages
Closed
vmishenev
requested changes
Aug 17, 2022
vmishenev
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2576
The main idea is that declarations without platform tabs can be considered to be "common" by default
The problem with rendering single "common" platform tab everywhere is that it attracts too much attention with the current changes, but doesn't bring that much value. This ought to make package overview page more minimalistic.