Apply the same style to all KDoc tags, including throws/see/parameters #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vmishenev
requested changes
Jul 27, 2022
| @@ -537,7 +537,7 @@ open class DefaultPageCreator( | |||
| val params = tags.withTypeNamed<Param>() | |||
| val availablePlatforms = params.values.flatMap { it.keys }.toSet() | |||
|
|
|||
| header(2, "Parameters", kind = ContentKind.Parameters, sourceSets = availablePlatforms) | |||
| header(4, "Parameters", kind = ContentKind.Parameters, sourceSets = availablePlatforms) | |||
There was a problem hiding this comment.
I think it is better to make a constant to avoid magic number.
| @@ -555,7 +555,9 @@ open class DefaultPageCreator( | |||
| kind = ContentKind.Parameters, | |||
| styles = mainStyles + ContentStyle.RowTitle | |||
| ) | |||
| comment(it.root) | |||
| if (it.root.children.isNotEmpty()) { | |||
There was a problem hiding this comment.
I would create a helper like TagWrapper.isEmpty() = children.isEmpty() (Law of Demeter)
I've fixed |
vmishenev
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2576
Now all KDoc tag sections should look the same, including throws/see/parameters
Decreased space between tag header and values
Fixed a problem where longer link text had many word breaks: