Do not generate source links for synthetic elements #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
reviewed
Jun 22, 2022
plugins/base/src/main/kotlin/transformers/pages/sourcelinks/SourceLinksTransformer.kt
Outdated
Show resolved
Hide resolved
IgnatBeresnev
force-pushed
the
2544-java-source-linking
branch
2 times, most recently
from
7511939
to
0f95b13
Compare
IgnatBeresnev
commented
Jun 23, 2022
| context.plugin<DokkaBase>().querySingle { commentsToContentConverter }, | ||
| context.plugin<DokkaBase>().querySingle { signatureProvider }, | ||
| context.logger | ||
| ) | ||
|
|
||
| override fun invoke(input: RootPageNode) = | ||
| input.transformContentPagesTree { node -> | ||
| override fun invoke(input: RootPageNode): RootPageNode { |
There was a problem hiding this comment.
A bit of refactoring to make it not run if sources are not configured and to not parse configuration on every documentable
IgnatBeresnev
commented
Jun 23, 2022
| @@ -85,7 +85,7 @@ abstract class AbstractTest<M : TestMethods, T : TestBuilder<M>, D : DokkaTestGe | |||
| }.toSet(), | |||
| sourceLinks = sourceSet.sourceLinks.map { link -> | |||
| link.copy( | |||
| localDirectory = testDirPath.toFile().resolve(link.localDirectory).canonicalPath | |||
| localDirectory = testDirPath.toFile().resolve(link.localDirectory).absolutePath | |||
There was a problem hiding this comment.
The problem with paths was here. canonicalPath resolves symlinks, while absolutePath does not, so on windows it resulted in two different temp folder locations.
I'll refactor this bit later on in a separate PR once I get a hold of a windows machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2544