Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont escape text inside gfm code blocks #2541

Merged
merged 1 commit into from Jun 19, 2022
Merged

Conversation

IgnatBeresnev
Copy link
Member

@IgnatBeresnev IgnatBeresnev commented Jun 17, 2022

Previously it generated trailing slashes for newlines inside code blocks + performed htmlEscape() on code text, which resulted in something like this:


Completion of an active coroutine's body or a call to CompletableJob.complete transitions the job to the completing state. It waits in the completing state for all its children to complete before transitioning to the completed state. Note that completing state is purely internal to the job. For an outside observer a completing job is still active, while internally it is waiting for its children.

                                          wait children\
    +-----+ start  +--------+ complete   +-------------+  finish  +-----------+\
    | New | -----> | Active | ---------> | Completing  | -------> | Completed |\
    +-----+        +--------+            +-------------+          +-----------+\
                     |  cancel / fail       |\
                     |     +----------------+\
                     |     |\
                     V     V\
                 +------------+                           finish  +-----------+\
                 | Cancelling | --------------------------------> | Cancelled |\
                 +------------+                                   +-----------+

A Job instance in the coroutineContext represents the coroutine itself.

@IgnatBeresnev IgnatBeresnev merged commit a11a8dd into master Jun 19, 2022
@IgnatBeresnev IgnatBeresnev deleted the gfm-regression branch June 19, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants