Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move source links into signature #2476

Merged
merged 3 commits into from Jul 29, 2022
Merged

Move source links into signature #2476

merged 3 commits into from Jul 29, 2022

Conversation

vmishenev
Copy link
Member

@vmishenev vmishenev commented Apr 27, 2022 •
edited

image

BUT
image

@vmishenev vmishenev linked an issue Apr 27, 2022 that may be closed by this pull request
Move source links into signatures #2467
Closed
@vmishenev vmishenev changed the title Move source link into signature Move source links into signature Apr 27, 2022
@vmishenev vmishenev force-pushed the move-source-links-into-signatures branch from c3765f5 to 8eb38d4 Compare April 27, 2022 22:15
@IgnatBeresnev IgnatBeresnev linked an issue Apr 28, 2022 that may be closed by this pull request
source link missing in case of overloads #2063
Closed
@vmishenev vmishenev linked an issue Apr 28, 2022 that may be closed by this pull request
Source link not shown for overloaded function #1877
Closed
@vmishenev vmishenev force-pushed the move-source-links-into-signatures branch 2 times, most recently from 5f96a47 to 86315b7 Compare July 26, 2022 21:20
@vmishenev vmishenev force-pushed the move-source-links-into-signatures branch from 86315b7 to d35f18e Compare July 26, 2022 21:45
IgnatBeresnev
IgnatBeresnev reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a simple rendering test with multiple signatures on the page (function overload) and assert that each signature has its own source button with the correct link, to avoid regressions later on?

core/src/main/kotlin/pages/ContentNodes.kt Outdated Show resolved Hide resolved
plugins/base/src/main/kotlin/transformers/pages/sourcelinks/SourceLinksTransformer.kt Outdated Show resolved Hide resolved
plugins/base/src/main/resources/dokka/styles/style.css Outdated Show resolved Hide resolved
plugins/base/src/main/kotlin/transformers/pages/sourcelinks/SourceLinksTransformer.kt Outdated Show resolved Hide resolved
@vmishenev vmishenev merged commit 018af7d into master Jul 29, 2022
@vmishenev vmishenev deleted the move-source-links-into-signatures branch July 29, 2022 20:20
@Claudemirovsky Claudemirovsky mentioned this pull request Feb 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnatBeresnev IgnatBeresnev IgnatBeresnev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vmishenev @IgnatBeresnev