GFM renderer: cleanup paragraphs and tables #1946
Merged
+379
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msink
changed the title
|
Hi, could you update the tests? |
Tests has been updated from the beginning, did I miss some? |
msink
force-pushed
the
gfm-cleanup-2
branch
3 times, most recently
from
9997fc1 to
3ab8e13
Compare
|
fixed |
Table with extra cell in row is really generated by `all-modules-page` plugin
|
Hi, is the PR ready for review? |
|
I hope yes, this time all tests passed and two extra tests added In fact I'm waiting for this merged (maybe after some review comments and fixes) to continue cleanup and implementing missed features. But - if you want it in bigger steps - started refactoring in #1964 |
This was referenced Jun 11, 2021
kamildoleglo
suggested changes
Jun 15, 2021
plugins/gfm/src/main/kotlin/org/jetbrains/dokka/gfm/renderer/CommonmarkRenderer.kt
Outdated
Show resolved
Hide resolved
plugins/gfm/src/main/kotlin/org/jetbrains/dokka/gfm/renderer/CommonmarkRenderer.kt
Outdated
Show resolved
Hide resolved
msink
added a commit
to msink/kotlin-libui
that referenced
this pull request
Jun 20, 2021
|
So - if only the |
MarcinAman
approved these changes
Jun 22, 2021
msink
added a commit
to msink/kotlin-libui
that referenced
this pull request
Jun 22, 2021
msink
added a commit
to msink/kotlin-libui
that referenced
this pull request
Jun 25, 2021
msink
added a commit
to msink/kotlin-libui
that referenced
this pull request
Jun 25, 2021
…nature and a brief comment Fixed a bug with `mapTransform` function which replaces table headers with their contents
kamildoleglo
force-pushed
the
gfm-cleanup-2
branch
from
9895b2e to
195648a
Compare
kamildoleglo
approved these changes
Jun 25, 2021
|
Thanks! |
msink
added a commit
to msink/kotlin-libui
that referenced
this pull request
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready for review and merge
Fixes #1853